Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle terraform providers in kubernetes-fluentd image #1145

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Bundle terraform providers in kubernetes-fluentd image #1145

merged 2 commits into from
Nov 23, 2020

Conversation

pmalek-sumo
Copy link
Contributor

Description
  • bump terraform from 0.12.26 to 0.12.29
  • relax sumologic terraform provider version constraint to update up to (excluding) 3.0.0 when possible (instead of 2.5.0)
  • use the same image - .Values.image.repository for cleanup job (instead of hashicorp:terraform
  • bundle terraform providers (kubernetes and sumologic) in sumologic:kubernetes-fluentd image (in /terraform/.terraform)
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@pmalek-sumo pmalek-sumo requested a review from a team November 23, 2020 12:12
@pmalek-sumo pmalek-sumo self-assigned this Nov 23, 2020
@pmalek-sumo pmalek-sumo linked an issue Nov 23, 2020 that may be closed by this pull request
Predownload Terraform plugins for the setup job so that they are available in the image #894
Closed
perk-sumo
perk-sumo approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

sumo-drosiek
sumo-drosiek approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix test

@pmalek-sumo pmalek-sumo merged commit 531479d into master Nov 23, 2020
@pmalek-sumo pmalek-sumo deleted the bundle-terraform-in-docker-image branch November 23, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@perk-sumo perk-sumo perk-sumo approved these changes

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

@kasia-kujawa kasia-kujawa Awaiting requested review from kasia-kujawa

@frankreno frankreno Awaiting requested review from frankreno

Assignees

@pmalek-sumo pmalek-sumo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Predownload Terraform plugins for the setup job so that they are available in the image
4 participants
@pmalek-sumo @sumo-drosiek @perk-sumo @pmalek