Helm Chart initial commit #118

maimaisie · 2019-08-02T18:28:30Z

Create the Helm chart. Dependencies and automation of yaml generation will be in separate PRs.

Output of helm install:

$ helm install helm/sumologic
NAME:   giggly-pike
LAST DEPLOYED: Fri Aug  2 11:24:49 2019
NAMESPACE: default
STATUS: DEPLOYED

RESOURCES:
==> v1/ConfigMap
NAME                                 DATA  AGE
giggly-pike-sumologic-config         9     1s
giggly-pike-sumologic-events-config  2     1s

==> v1/Deployment
NAME                          READY  UP-TO-DATE  AVAILABLE  AGE
giggly-pike-sumologic         0/3    3           0          0s
giggly-pike-sumologic-events  0/1    1           0          0s

==> v1/Pod(related)
NAME                                           READY  STATUS             RESTARTS  AGE
giggly-pike-sumologic-d5dc9d85d-9ptld          0/1    Pending            0         0s
giggly-pike-sumologic-d5dc9d85d-b6sxd          0/1    Pending            0         0s
giggly-pike-sumologic-d5dc9d85d-kfhc2          0/1    Pending            0         0s
giggly-pike-sumologic-events-5db58c487d-9f722  0/1    ContainerCreating  0         0s

==> v1/Service
NAME                          TYPE       CLUSTER-IP     EXTERNAL-IP  PORT(S)                       AGE
giggly-pike-sumologic         ClusterIP  10.101.92.220  <none>       9888/TCP,24321/TCP,24231/TCP  0s
giggly-pike-sumologic-events  ClusterIP  10.99.214.103  <none>       24231/TCP                     0s

==> v1/ServiceAccount
NAME                   SECRETS  AGE
giggly-pike-sumologic  1        1s

==> v1beta1/ClusterRole
NAME                   AGE
giggly-pike-sumologic  1s

==> v1beta1/ClusterRoleBinding
NAME                   AGE
giggly-pike-sumologic  0s

rvmiller89 · 2019-08-02T20:20:38Z

$ helm install helm/sumologic
NAME:   giggly-pike

what is giggly-pike ?

maimaisie · 2019-08-02T20:22:41Z

That is a randomly generated release name. You can override release name by passing in the --name flag to helm install

rvmiller89 · 2019-08-02T20:23:48Z

Can we provide a default release name to avoid this without having the customer specify --name flag?

rvmiller89

LGTM

deploy/helm/sumologic/values.yaml

deploy/helm/sumologic/conf/events/events.conf

yuting-liu

LGTM overall

deploy/helm/sumologic/Chart.yaml

maimaisie · 2019-08-02T20:48:25Z

deploy/helm/sumologic/templates/_helpers.tpl

+{{/*
+Create a default fully qualified app name.
+We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).
+If dryRun=true, we use fixed value "fluentd".


when we need to generate yaml files, we would set dryRun (for the lack of a better name) to true to use fixed values for release name and the app label
eg.
helm template ./sumologic --set dryRun=true --namespace sumologic

why do we need this?

this is such that the generated yaml for non-helm users will be consistent with the yaml we currently provide in the repo. for example our current yaml uses fluentd as the name for a lot of resources but in helm we would prefix with the release name followed by the chart name

rvmiller89 · 2019-08-05T20:03:35Z

What does the helm install command look like to also pass prometheus-overrides.yaml and fluentbit-overrides.yaml ?

frankreno

Overall, LGTM but some comments

deploy/helm/sumologic/Chart.yaml

deploy/helm/sumologic/conf/events/events.conf

frankreno · 2019-08-05T19:59:01Z

deploy/helm/sumologic/templates/_helpers.tpl

+{{/*
+Create a default fully qualified app name.
+We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).
+If dryRun=true, we use fixed value "fluentd".


why do we need this?

deploy/helm/sumologic/templates/_helpers.tpl

frankreno · 2019-08-05T20:03:17Z

deploy/helm/sumologic/values.yaml

+image:
+  repository: sumologic/kubernetes-fluentd
+  tag: 0.0.0
+  pullPolicy: Always


When we do make this officially released, this should default to IfNotPresent, not always.

maimaisie · 2019-08-05T20:12:44Z

What does the helm install command look like to also pass prometheus-overrides.yaml and fluentbit-overrides.yaml ?

@yuting-liu is looking into adding the dependencies into the chart and it will be done in a separate PR. The chart in the current PR will not install prometheus or fluent-bit

…s to values.yaml

lei-sumo · 2019-08-07T20:29:47Z

deploy/helm/sumologic/values.yaml

+  flushInterval: 5
+
+  ## Increase number of http threads to Sumo. May be required in heavy logging clusters
+  numThreads: 1


I think we changed default to 4?

maimaisie added 2 commits August 2, 2019 11:22

Helm Chart initial commit

c268487

Change description

2286bb9

maimaisie requested review from rvmiller89, yuting-liu, samjsong, frankreno and lei-sumo August 2, 2019 18:28

rvmiller89 previously approved these changes Aug 2, 2019

View reviewed changes

deploy/helm/sumologic/values.yaml Outdated Show resolved Hide resolved

maimaisie commented Aug 2, 2019

View reviewed changes

deploy/helm/sumologic/conf/events/events.conf Outdated Show resolved Hide resolved

yuting-liu previously approved these changes Aug 2, 2019

View reviewed changes

deploy/helm/sumologic/Chart.yaml Outdated Show resolved Hide resolved

maimaisie commented Aug 2, 2019

View reviewed changes

Remove comments in values.yaml

dac8fea

frankreno previously approved these changes Aug 5, 2019

View reviewed changes

Fix namespace in events.conf

969eb7b

maimaisie dismissed stale reviews from frankreno, yuting-liu, and rvmiller89 via 969eb7b August 5, 2019 20:09

maimaisie added 2 commits August 6, 2019 10:52

Remove fluentdUserConfig and fluentdUserConfigEvents

974984f

Expose fluentdLogLevel and watchResourceEventsOverrides. Add some doc…

4b957d1

…s to values.yaml

yuting-liu mentioned this pull request Aug 6, 2019

SUMO-115354 Add dependencies with overridden values.yaml #126

Closed

samjsong previously approved these changes Aug 6, 2019

View reviewed changes

Change appVersion to 0.0.0

318b102

maimaisie dismissed samjsong’s stale review via 318b102 August 7, 2019 18:05

lei-sumo approved these changes Aug 7, 2019

View reviewed changes

maimaisie merged commit 4de4b66 into master Aug 7, 2019

maimaisie deleted the maisie-helm-chart branch August 7, 2019 18:26

lei-sumo reviewed Aug 7, 2019

View reviewed changes

psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021

Add nytimes-spg-settlements as sumo sourceCategory (SumoLogic#118)

b306940

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Helm Chart initial commit #118

Helm Chart initial commit #118

maimaisie commented Aug 2, 2019 •

edited

Loading

rvmiller89 commented Aug 2, 2019

maimaisie commented Aug 2, 2019

rvmiller89 commented Aug 2, 2019

rvmiller89 left a comment

yuting-liu left a comment

maimaisie Aug 2, 2019

frankreno Aug 5, 2019

maimaisie Aug 5, 2019

rvmiller89 commented Aug 5, 2019

frankreno left a comment

frankreno Aug 5, 2019

frankreno Aug 5, 2019

maimaisie commented Aug 5, 2019

lei-sumo Aug 7, 2019

Helm Chart initial commit #118

Helm Chart initial commit #118

Conversation

maimaisie commented Aug 2, 2019 • edited Loading

rvmiller89 commented Aug 2, 2019

maimaisie commented Aug 2, 2019

rvmiller89 commented Aug 2, 2019

rvmiller89 left a comment

Choose a reason for hiding this comment

yuting-liu left a comment

Choose a reason for hiding this comment

maimaisie Aug 2, 2019

Choose a reason for hiding this comment

frankreno Aug 5, 2019

Choose a reason for hiding this comment

maimaisie Aug 5, 2019

Choose a reason for hiding this comment

rvmiller89 commented Aug 5, 2019

frankreno left a comment

Choose a reason for hiding this comment

frankreno Aug 5, 2019

Choose a reason for hiding this comment

frankreno Aug 5, 2019

Choose a reason for hiding this comment

maimaisie commented Aug 5, 2019

lei-sumo Aug 7, 2019

Choose a reason for hiding this comment

maimaisie commented Aug 2, 2019 •

edited

Loading