Add pushing images to ghcr.io for release builds #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek-sumo
requested review from
andrzej-stencel,
frankreno,
kasia-kujawa,
perk-sumo and
sumo-drosiek
as code owners
sumo-drosiek
reviewed
Dec 4, 2020
| docker tag "${docker_tag}:local" "${GHCR_IO_DOCKER_TAG}" | ||
| echo "Pushing docker image ${GHCR_IO_DOCKER_TAG}..." | ||
| docker push "${GHCR_IO_DOCKER_TAG}" | ||
| fi |
There was a problem hiding this comment.
Can we move it to the function and make it general by passing login, password, registry?
There was a problem hiding this comment.
I mean, push_docker_image should push image to a registry and you can eventually create push_docker_images which will check for gcrio, ecr, dockerhub, quay.io, etc. and will run push_docker_image with arguments for every of the registry
sumo-drosiek
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add pushing images to ghcr.io
Testing performed