-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check minimal k8s version before installation #1240
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
requested review from
andrzej-stencel,
frankreno,
kasia-kujawa and
perk-sumo
as code owners
December 15, 2020 08:11
sumo-drosiek
commented
Dec 15, 2020
sumo-drosiek
commented
Dec 15, 2020
perk-sumo
reviewed
Dec 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm overall good but please make it 2 commits (one for .gitignore and another for the changes) or split to 2 PRs.
andrzej-stencel
previously approved these changes
Dec 15, 2020
sumo-drosiek
force-pushed
the
drosiek-chck-mnml-k8s-vrsn
branch
from
December 15, 2020 08:48
7643475
to
3c1f741
Compare
@perk-sumo done |
andrzej-stencel
approved these changes
Dec 15, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1195
Testing performed