Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note On Possible Remote Write Update Changes #127

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

frankreno
Copy link
Contributor

For now, just updating docs, but we should think through a better solution. Update README with note on remote write API changes needed when deploying Prometheus to a different namespace or using an existing Prometheus running in a different namespace.

…ying Prometheus to a different namespace or using an existing Prometheus running in a different namespace.
@rvmiller89
Copy link
Contributor

wasn't sure if you wanted us to take a look at this, but it LGTM if you want to merge

deploy/README.md Outdated
@@ -204,6 +204,8 @@ Before installing `prometheus-operator`, edit `prometheus-overrides.yaml` to def

__NOTE__ It’s fine to change the value of the `cluster` field, but don’t change the field name (key).

__NOTE__ If you plan to install Prometheus in a a different namespace than you deployed FluentD to in Step 1, or you have an existing Prometheus you plan to apply our configuration to running in a different namespace, please update the remote write API configuration to use the full service url. e.g. `http://fluentd.sumologic.svc.cluster.local:9888`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: double "a"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :)

@frankreno frankreno merged commit f318df3 into master Aug 8, 2019
@perk-sumo perk-sumo deleted the freno-update-readme-remote-write branch May 21, 2020 16:30
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
* adding role for infra services team

* adding manager for OU resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants