Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract FLUENTD_METRICS_SVC from the CHART variable #1288

Merged

Conversation

perk-sumo
Copy link
Contributor

Description

Fill in your description here.


Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@perk-sumo perk-sumo requested a review from a team January 5, 2021 13:29
@perk-sumo perk-sumo force-pushed the perk-split-chart-into-separate-fluentd-service-names branch from c0b3851 to 035caad Compare January 5, 2021 13:50
andrzej-stencel
andrzej-stencel previously approved these changes Jan 5, 2021
@pmalek-sumo pmalek-sumo force-pushed the perk-split-chart-into-separate-fluentd-service-names branch from 6fe1b1f to 445a31f Compare January 5, 2021 15:09
@perk-sumo perk-sumo force-pushed the perk-split-chart-into-separate-fluentd-service-names branch from 445a31f to 7de202c Compare January 5, 2021 16:44
@perk-sumo perk-sumo changed the title Extract FLUENTD_LOGS_SVC and FLUENTD_METRICS_SVC from the CHART variable Extract FLUENTD_METRICS_SVC from the CHART variable Jan 5, 2021
@perk-sumo perk-sumo force-pushed the perk-split-chart-into-separate-fluentd-service-names branch 2 times, most recently from 7de202c to 31f743c Compare January 5, 2021 16:53
Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bear in mind that we need to migrate fluent-bit which uses CHART env variable (and this has not been taken into account in this PR)

@perk-sumo
Copy link
Contributor Author

perk-sumo commented Jan 5, 2021

The fluent bit part has been extracted into another PR: #1289

@perk-sumo perk-sumo merged commit 87ef3c7 into main Jan 5, 2021
@perk-sumo perk-sumo deleted the perk-split-chart-into-separate-fluentd-service-names branch January 5, 2021 17:04
@perk-sumo perk-sumo added this to the v2.0 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants