-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUMO-115354 Add dependencies with overridden values.yaml #132
Conversation
For overridden values for
Since two copies of overridden values for our dependencies, there will be configuration drift between them. We need to discuss whether this drift is acceptable based on how frequently we are going to change overridden values for these two dependencies. The reason why we cannot pass in
When we defined
There are some options we can do to reduce the configuration drift:
|
This will probably be merged while I'm on PTO, but I'd like to leave my 2 cents: We should not copy-paste the same config in multiple files. We should try to find a way to avoid this, either through reading the Helm docs, or integrating this into our CI. |
Will discuss offline about how to maintain the copies of overridden values for dependencies today. |
dependencies: | ||
- name: fluent-bit | ||
repository: https://kubernetes-charts.storage.googleapis.com/ | ||
version: 2.4.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did you decide on these versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now what I decided. This file is autogenerated by running helm install
. It get the version 2.4.4
from the version we specified for version: ~2.4.0
in requirements.yaml
.
https://stackoverflow.com/questions/53702445/use-of-requirements-lock-file-in-helm-charts
As here it shows that how it works:
- After created initial
requirements.yaml
file. You runhelm install
and helm createsrequirements.lock
file as it builds the dependency tree. - On the next helm install, helm will ensure that it uses the same versions identified in the
requirements.lock
file. - At some later date, you update
requirements.yaml
file. You runhelm install
(orhelm upgrade
) and helm will notice your changes and update therequirements.lock
file to reflect them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did you decide to use version: ~2.4.0
in the yaml file then? and is the auto-generated version 2.4.4
the latest version after version: ~2.4.0
or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~2.4.0
is a patch-level version match (suggested by helm), which means >=2.4.0 and <2.5.0
. And 2.4.4
is auto generated then. Here I used the latest patch level version officially provided by fluent-bit. Maybe we need to ask @samjsong to make sure whether there is some explicit requirements for fluent-bit version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know of any explicit requirements for fluent bit version, I've just been using latest for now, I'm assuming this is fine and can be upgraded in the future if there are updates we want to include
e3b2932
to
937fd78
Compare
086fe0d
to
64d7c5b
Compare
Only pass in our own yamls to helm template cmd
…ic-kubernetes-collection into yuting-helm-dependency
040e01a
to
0d9944e
Compare
c402616
to
53cdab5
Compare
…/sumologic-kubernetes-collection into yuting-helm-dependency
a3db0ef
to
bab5843
Compare
Sorry for the long commit history 😂 but this PR is now ready for review |
dependencies: | ||
- name: fluent-bit | ||
repository: https://kubernetes-charts.storage.googleapis.com/ | ||
version: 2.4.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know of any explicit requirements for fluent bit version, I've just been using latest for now, I'm assuming this is fine and can be upgraded in the future if there are updates we want to include
Add following dependencies for our fluentd plugin:
For versions defined for these two dependencies in
requirements.yaml
, we used the latest release version~2.4.0
forfluent-bit
and~6.2.0
forprometheus-operator
. In slack conversation https://sumologic.slack.com/archives/GFJ6U4SCE/p1565109513061400, the version6.2.0
is explicitly specified for use of--no-crd-hook
.