Move fluent-bit INPUT config to overrides yaml #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei-sumo
reviewed
Aug 12, 2019
| @INCLUDE fluent-bit-input.conf | ||
| @INCLUDE fluent-bit-output.conf | ||
|
|
||
| [INPUT] |
There was a problem hiding this comment.
Will extraEntries.input help to expose the knobs we want?
There was a problem hiding this comment.
Unfortunately not. There's two issues with extraEntries.input:
- Since
Refresh_Interval 5is already hard coded in line 33, we cannot configure this parameter. - Since
extraEntries.inputis on line 50, after the systemd section, any configuration will be inserted to the systemd section, not the tail section. So if we want to specifyRotate_WaitwithextraEntries.input, we cannot use the systemd section (input.systemd.enabledmust be set to false).
yuting-liu
approved these changes
Aug 12, 2019
maimaisie
approved these changes
Aug 12, 2019
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the OOB fluent-bit helm chart does not expose configs for
Refresh_IntervalandRotate_Wait, we decided to expose the[INPUT]config for fluent-bit explicitly in the overrides yaml file.For reference, this was the helm chart's
[INPUT]config. We need to keep.Values.input.systemd.enabledand.Values. trackOffsetsin our overrides since they are used here.Testing performed