-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The v2 migration script fix - migrate Fluent Bit image key instead of deleting it #1444
Merged
perk-sumo
merged 2 commits into
main
from
perk-fix-upgrade-v2-script-migrate-fluent-bit-image
Feb 19, 2021
Merged
The v2 migration script fix - migrate Fluent Bit image key instead of deleting it #1444
perk-sumo
merged 2 commits into
main
from
perk-fix-upgrade-v2-script-migrate-fluent-bit-image
Feb 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perk-sumo
requested review from
andrzej-stencel,
frankreno,
kasia-kujawa,
pmalek-sumo and
sumo-drosiek
as code owners
February 18, 2021 16:42
pmalek-sumo
approved these changes
Feb 18, 2021
perk-sumo
changed the title
fix: v2 migration script - migrate Fluent Bit image key instead of de…
The v2 migration script fix - migrate Fluent Bit image key instead of deleting it
Feb 18, 2021
perk-sumo
force-pushed
the
perk-fix-upgrade-v2-script-migrate-fluent-bit-image
branch
2 times, most recently
from
February 19, 2021 08:50
786e80a
to
9dcb54c
Compare
perk-sumo
force-pushed
the
perk-fix-upgrade-v2-script-migrate-fluent-bit-image
branch
2 times, most recently
from
February 19, 2021 09:46
327cebf
to
9fa72a4
Compare
perk-sumo
requested review from
andrzej-stencel,
sumo-drosiek and
pmalek-sumo
February 19, 2021 09:48
perk-sumo
force-pushed
the
perk-fix-upgrade-v2-script-migrate-fluent-bit-image
branch
2 times, most recently
from
February 19, 2021 11:31
b178b60
to
8257ea9
Compare
…stead of deleting it
…mage.pullPolicy key instead of just adding it
perk-sumo
force-pushed
the
perk-fix-upgrade-v2-script-migrate-fluent-bit-image
branch
from
February 19, 2021 11:40
8257ea9
to
577e2a8
Compare
sumo-drosiek
approved these changes
Feb 19, 2021
perk-sumo
deleted the
perk-fix-upgrade-v2-script-migrate-fluent-bit-image
branch
February 19, 2021 12:24
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-v2.0 release-v2.0
# Navigate to the new working tree
cd .worktrees/backport-release-v2.0
# Create a new branch
git switch --create backport-1444-to-release-v2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 5243583091113114e05d79d6a1d533d00e2b2ded
# Push it to GitHub
git push --set-upstream origin backport-1444-to-release-v2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-v2.0 Then, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert this: https://github.com/helm/charts/blob/master/stable/fluent-bit/values.yaml#L5
into this: https://github.com/fluent/helm-charts/blob/fb1f611236a3d4b4f56514bb1d05b23820f8a409/charts/fluent-bit/values.yaml#L9