Check API errors when getting fields quota in setup job #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek-sumo
requested review from
andrzej-stencel,
frankreno,
kasia-kujawa,
perk-sumo and
sumo-drosiek
as code owners
perk-sumo
reviewed
Mar 24, 2021
perk-sumo
approved these changes
Mar 24, 2021
pmalek-sumo
force-pushed
the
setup-job-check-errors-when-getting-fields-quota-from-api
branch
from
19cba50
to
3348423
Compare
pmalek-sumo
deleted the
setup-job-check-errors-when-getting-fields-quota-from-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whenever a user encounters an error that is received from Sumo Logic API it's somehow lost.
This PR addresses that by explicitly checking for expected
.remainingkey in the returned JSON and it explicitly logs the received JSON whenever an error occurs.Fixes: #1523