Add kubelet, systemd filtration and refactor containers exporter #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sumo-drosiek
commented
Sep 21, 2021
•
sumo-drosiek
commented
- unify exporting for systemd, collectd and containers logs
- add filtration for systemd like we already have in fluentd
- add kubelet pipeline
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
added 4 commits
September 21, 2021 10:12
… in exporter Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-kubelet
branch
from
d875407
to
4cda8ac
Compare
pmalek-sumo
reviewed
Sep 21, 2021
deploy/helm/sumologic/values.yaml
Outdated
Comment on lines
3003
to
3004
| - attributes/remove_fluent_tag | ||
| - filter/include_kubelet |
There was a problem hiding this comment.
Actually as I think of it now I believe we can swap those 2 to save processing of "non kubelet" entries, i.e. no need to remove the fluent.tag from a record that will be filtered out anyway.
The same can be done for systemd
There was a problem hiding this comment.
so we should move it as far as possible, we have additional filtering in sourceprocessor for example
There was a problem hiding this comment.
What do you mean "as far as possible"? Shouldn't we filter out as soon as possible in the pipeline?
There was a problem hiding this comment.
I mean moving - attributes/remove_fluent_tag just before batch
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
pmalek-sumo
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.