Simplify Metrics FluentD Pipeline #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date steps in readme with details on how to do this with a seperate HTTP source.
samjsong
approved these changes
Sep 6, 2019
Good catch! fixed |
drduke1
suggested changes
Sep 6, 2019
drduke1
approved these changes
Sep 6, 2019
rvmiller89
suggested changes
Sep 7, 2019
deploy/README.md
Outdated
| - [Step 2: Setup a service monitor so that Prometheus pulls the data](#step-2-setup-a-service-monitor-so-that-prometheus-pulls-the-data) | ||
| - [Step 3: Update the prometheus-overrides.yaml file to forward the metrics to Sumo.](#step-3-update-the-prometheus-overridesyaml-file-to-forward-the-metrics-to-sumo) | ||
| - [Step 2: Set up a service monitor so that Prometheus pulls the data](#step-2-set-up-a-service-monitor-so-that-prometheus-pulls-the-data) | ||
| - [Step 3: Step 3: Create a new HTTP source in Sumo Logic.](#step-3-create-a-new-http-source-in-sumo-logic) |
There was a problem hiding this comment.
Step 3: is written twice here
There was a problem hiding this comment.
did you commit the change? still written twice
There was a problem hiding this comment.
hrmm its weird, i don't see this locally
rvmiller89
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplify fluentD routing, make it easier to add custom metrics and update steps in readme with details on how to do this with a seperate HTTP source.