-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): add PodDisruptionBudget api version helm chart helpers #1865
feat(helm): add PodDisruptionBudget api version helm chart helpers #1865
Conversation
This will require some more work in tests since we need to pass in api versions to
but we don't want to hardcode those and we'd like to make this configurable per test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request contains invalid labels. Please remove all of the following labels: ['do-not-merge/hold']
26c0d4b
to
fa647f7
Compare
4acbad3
to
924dd22
Compare
924dd22
to
e8aeda7
Compare
e8aeda7
to
cfeac0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, the end state is OK, thanks for working on that!
But 😅
I don't like the commit history here, please either fix the history or squash the PR before merge.
squashed :) Thanks! |
The idea behind this change is to support newer version of
PodDisruptionBudget
(policy/v1beta1/PodDisruptionBudget
vspolicy/v1/PodDisruptionBudget
)and to get rid of deprecation warnings when installing our chart: