-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency upgrades for ARM support #1919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a Changelog entry with all those changes
62054ec
to
2367f20
Compare
.github/pull_request_template.md
Outdated
##### Checklist | ||
|
||
Remove items which don't apply to your PR. | ||
|
||
- [ ] Changelog updated | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
piggybacking on this PR 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can submit this change separately if you want 🙄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better practice IMHO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allright, see #1922
2367f20
to
778b4f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the PR template this looks really good 👍
778b4f3
to
9849db5
Compare
Telegraf-operator added ARM support in 1.3.0, and the Helm chart ties the binary version to the chart version. Upgrade the chart so we can run on ARM.
Use the gcr repo, which has ARM images starting from this version.
This gives us ARM support, primarily.
This includes ARM support and brings us closer to supporting the entirety of collection on ARM.
7fd8801
to
f1ffaeb
Compare
f1ffaeb
to
b75a67e
Compare
Description
Updating some dependencies necessary for ARM support:
I updated the tools version to 2.6.0 everywhere we explicitly mention it in the documentation. I think this is fine, but let me know if you see some kind of problem.
Ran E2E tests on this and they passed.
Testing performed