Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to disable service enrichment #1936

Merged

Conversation

andrzej-stencel
Copy link
Contributor

No description provided.

@andrzej-stencel andrzej-stencel requested a review from a team as a code owner December 6, 2021 14:03
@github-actions github-actions bot added the documentation documentation label Dec 6, 2021
Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog 🤡

@@ -220,7 +220,7 @@ sumologic:
fluentd:
image:
repository: public.ecr.aws/sumologic/kubernetes-fluentd
tag: 1.12.2-sumo-10
tag: 1.12.2-sumo-11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe they just build longer than they used to - so while it's 🎉 that it was caught - there is no real error, we just need for images to be published (which is happening, just slow).
Ref https://github.com/SumoLogic/sumologic-kubernetes-fluentd/actions/runs/1544893588

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't matter if it's fast or slow. At the moment you merge this PR this image has to be available. No tricks, no postponing, no rushing things. When it's available then we can merge it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's something to shorten the Fluentd release time: SumoLogic/sumologic-kubernetes-fluentd#371

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt publishing changes will make a difference. Most of the time is spent building the image for ARM, which tends to be very slow in QEMU. If we want it to be faster, we can add a build cache and/or try not to build native extensions during the image build process, which is what takes the lion's share of the time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a recent blog from Docker on this very topic https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/, but I'm afraid it might not apply for our Ruby image build.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, cross-compiling ruby extensions is probably not the easiest way of improving this process. I bet we could get quite far by configuring caching correctly for buildx, which isn't very difficult, but ECR doesn't support it yet.

@perk-sumo perk-sumo added this to the v2.3 milestone Dec 6, 2021
@andrzej-stencel andrzej-stencel force-pushed the feat-add-option-to-disable-service-enrichment branch from 9b0ec72 to 9e94f3d Compare December 6, 2021 14:20
@andrzej-stencel andrzej-stencel merged commit ec97f5e into main Dec 6, 2021
@andrzej-stencel andrzej-stencel deleted the feat-add-option-to-disable-service-enrichment branch December 6, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants