Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-v2.4] chore: update Telegraf to 1.21.2 #2052

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

swiatekm
Copy link

@swiatekm swiatekm commented Jan 27, 2022

Description

Backport the Telegraf update to 2.4.


Checklist
  • Changelog updated

@swiatekm swiatekm requested a review from a team as a code owner January 27, 2022 16:26
@github-actions github-actions bot added the documentation documentation label Jan 27, 2022
@swiatekm swiatekm force-pushed the backport/v2.4/update-telegraf branch from 32ebc6c to 0f22c41 Compare January 27, 2022 16:27
Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we didn't establish that we won't be backporting this 🤔 .

@@ -5,6 +5,19 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secondly I just thought about (IMHO) a nice idea how to mark the next release, that yet unreleased. See the below suggestion.

Suggested change
## [Unreleased]
## v2.4.1
### Unreleased

WDYT? (obviously we can tweak that)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be a bit confusing if someone were to look at the branch and see the version in the changelog without an accompanying release tag. I think that's the reason we don't do this in main either.

@swiatekm
Copy link
Author

I'm not sure if we didn't establish that we won't be backporting this 🤔 .

We agreed on 2.4, but not earlier versions. In general, I think it's good to backport relatively minor (in scope) security upgrades to the latest major version.

@swiatekm swiatekm merged commit 7d449eb into release-v2.4 Jan 28, 2022
@swiatekm swiatekm deleted the backport/v2.4/update-telegraf branch January 28, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants