feat(ot-operator): add opentelemetry-operator for tracing #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mat-rumian
changed the title
mat-rumian
force-pushed
the
feat-ot-operator-for-tracing
branch
from
fb3818b
to
ab56462
Compare
mat-rumian
changed the title
pmalek-sumo
reviewed
Mar 11, 2022
mat-rumian
changed the title
pmalek-sumo
suggested changes
Mar 15, 2022
tests/integration/main_test.go
Outdated
Comment on lines
67
to
68
| // Helm chart installation extra arguments list | ||
| helmExtraArgs := []string{"--wait"} |
There was a problem hiding this comment.
These are not really helm extra args but helm install extra args.
I believe we can actually put this into the SetHelmOptionsTestOpt and not expose here 🤔
Comment on lines
11
to
18
| # Prevent snowball effect by filtering out receiver mock logs | ||
| fluent-bit: | ||
| config: | ||
| filters: | | ||
| [FILTER] | ||
| Name grep | ||
| Match containers.var.log.containers.receiver-mock* | ||
| Exclude log .* |
There was a problem hiding this comment.
I believe that given the logs are disabled now, this is not needed anymore.
Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
pmalek-sumo
reviewed
Mar 30, 2022
sumo-drosiek
reviewed
Jun 6, 2022
sumo-drosiek
reviewed
Jun 6, 2022
# Conflicts: # CHANGELOG.md # tests/integration/go.mod # tests/integration/go.sum
sumo-drosiek
approved these changes
Jun 7, 2022
# Conflicts: # tests/integration/go.mod # tests/integration/go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OpenTelemetry-Operator functionalities in addition with automatically created
Instrumentationcustom resource in specified namespaces provided byopentelemetry-operator.manager.env.WATCH_NAMESPACE.cert-manageris not required to be installed. Needed certificates are generated during chart deployment.Checklist
Testing performed