Fix fluentd log level parameter #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvmiller89
approved these changes
Oct 4, 2019
lei-sumo
approved these changes
Oct 4, 2019
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
* add multimedia role * Fix group_manager Co-authored-by: Mel Cone <7332210+melmaliacone@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first issue is we were incorrectly accessing
fluentdLogLevelin the templates, we should be using.Values.sumologic.fluentdLogLevelinstead of.Values.fluentdLogLevel. The second issue that Sam noticed was fluentd could not start if the<system>block is defined twice. The fix for that is to have<system>block defined once in the logs and metrics config map (in common.conf) and once in the events config map.Testing performed