Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(setup): monitors in integrations folder #2274

Merged
merged 7 commits into from
May 6, 2022
Merged

feat(setup): monitors in integrations folder #2274

merged 7 commits into from
May 6, 2022

Conversation

starzu-sumo
Copy link
Contributor

@starzu-sumo starzu-sumo commented May 6, 2022 •
edited
Loading

Description

Changes:

  • the monitors will be installed inside "Sumo Logic Integrations > Kubernetes" folder
  • sumologic.setup.monitors.notificationEmails is able to handle a single email passed as a string
  • fix: removed spaces from variables in email templates
Checklist
  • Changelog updated
Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@github-actions github-actions bot added the documentation documentation label May 6, 2022
@starzu-sumo starzu-sumo marked this pull request as ready for review May 6, 2022 08:19
@starzu-sumo starzu-sumo requested a review from a team as a code owner May 6, 2022 08:19
sumo-drosiek
sumo-drosiek approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumo-drosiek sumo-drosiek added this to the v2.8 milestone May 6, 2022
@sumo-drosiek sumo-drosiek merged commit 41181bd into SumoLogic:main May 6, 2022
@sumo-drosiek sumo-drosiek changed the title Monitors in integrations folder feat: monitors in integrations folder May 6, 2022
@starzu-sumo starzu-sumo deleted the mstarzec-monitors-in-integrations branch May 6, 2022 11:36
@sumo-drosiek sumo-drosiek changed the title feat: monitors in integrations folder feat(setup): monitors in integrations folder May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

Assignees
No one assigned
Labels
documentation documentation
Projects
None yet
Milestone
v2.8
Development

Successfully merging this pull request may close these issues.
2 participants
@starzu-sumo @sumo-drosiek