-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding toleration and affinity #2428
Conversation
this fixes issue #2424 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@severity1 Thank you for the contribution
It would be awesome if you add missing configuration to chart's README.md as well
Hi @sumo-drosiek, README.md has been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I will fix the non-related markdown table changes in separate PR
I won't as this is required check 😅 I added two small suggestion and we are ready to go |
Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
@severity1 Thanks for quick reaction, we just need to reformat table. If you have some automation tool it would be better to use, otherwise I hope the latest suggestion will resolve the issue |
@sumo-drosiek, thank you for your patience with me, I ran my auto-formatter against the README.md and it still gives an error. |
Seems like headers are the issue, as I run |
I think I found the issue |
my IDE was converting |
Yes, this was the issue. Apparently |
thank you @sumo-drosiek cheers! |
Change has been released: https://github.com/SumoLogic/sumologic-kubernetes-collection/releases/v2.12.0 |
Description
Adding the ability to configure toleration and affinity to the setup job.