Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tracing): add pprof extension to the collectors #2434

Merged
merged 4 commits into from
Jul 15, 2022
Merged

feat(tracing): add pprof extension to the collectors #2434

merged 4 commits into from
Jul 15, 2022

Conversation

mat-rumian
Copy link
Contributor

@mat-rumian mat-rumian commented Jul 14, 2022 •
edited
Loading

Description

PR adds pprof extension to the otelagent, otelgateway and otelcol collectors.

Checklist
  • Changelog updated
Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@mat-rumian mat-rumian requested a review from a team as a code owner July 14, 2022 15:50
@github-actions github-actions bot added the documentation documentation label Jul 14, 2022
pdelewski
pdelewski reviewed Jul 14, 2022
View reviewed changes
Copy link
Contributor

@pdelewski pdelewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this requested by customer(s)? or for development purposes?

@mat-rumian
Copy link
Contributor Author

Is this requested by customer(s)? or for development purposes?

It's more for us to have possibility to analyse what's going on on the collector side without configuration change.

sumo-drosiek
sumo-drosiek approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mat-rumian mat-rumian merged commit 0cd0499 into main Jul 15, 2022
@mat-rumian mat-rumian deleted the feat-pprof-tracing branch July 15, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@pdelewski pdelewski pdelewski approved these changes

Assignees
No one assigned
Labels
documentation documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mat-rumian @sumo-drosiek @pdelewski