-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: refactor event collection configuration #2444
Conversation
69d5b1e
to
139eeaf
Compare
00876ed
to
fcd9d10
Compare
I think we should mark it as |
We can add optional metadata enrichment and filtering as well, but generally wouldn't do anything unless we have explicit request/usecase for it |
It's a breaking change for many reasons, but I've also already marked it as such accoring to conventional commits - what else did you have in mind? |
gh label |
size: 10Gi | ||
path: /var/lib/storage/events | ||
accessMode: ReadWrite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this go to otelevents
configuration?
It sounds like more advanced and technical configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is nice, but not sure if persistence should go to the events
or otelevents
configuration
fcd9d10
to
5727ce1
Compare
Config migration PR: SumoLogic/sumologic-kubernetes-tools#305 |
As per offline discussion, I left persistence in the common config, but split off the K8s-specific bits. |
Please make linters happy :) |
1982bec
to
ec53150
Compare
d2804a4
to
6e21c58
Compare
6e21c58
to
a30da8c
Compare
a30da8c
to
8281df6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit
8281df6
to
5c7e0b9
Compare
Description
Move event configuration to the
sumologic.events
section, containing common configuration for OT and FluentD. This should also include switching to otelcol as the default provider, but I thought this would be easier to review without that change.With this change, provider-agnostic configuration for events includes:
I'm wondering if I shouldn't also expose something to more easily modify the OT pipeline - for example by letting the user add processors to the end of it. WDYT?
Checklist
Testing performed