Adjust queueing and batching configurarion for OTC according to testi… #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pdelewski
commented
Aug 18, 2022
| @@ -3977,7 +3977,7 @@ metadata: | |||
| ## ref: https://github.com/SumoLogic/opentelemetry-collector/blob/main/processor/batchprocessor | |||
| batch: | |||
| ## Number of spans after which a batch will be sent regardless of time | |||
| send_batch_size: 16_384 | |||
| send_batch_size: 1_024 | |||
| ## Time duration after which a batch will be sent regardless of size | |||
| timeout: 30s | |||
There was a problem hiding this comment.
Should we update timeout as well?
There was a problem hiding this comment.
Yeah, a lower value like 1s is better imo.
There was a problem hiding this comment.
I will update that
pdelewski
force-pushed
the
SUMO-186628-Adjust-queueing-and-batching-configurarion-for-OTC
branch
2 times, most recently
from
ef1d6f8
to
9f8b086
Compare
pdelewski
force-pushed
the
SUMO-186628-Adjust-queueing-and-batching-configurarion-for-OTC
branch
from
9f8b086
to
0c61160
Compare
swiatekm
approved these changes
Aug 18, 2022
From what I see, originally it was done only for metrics, so I updated only metrics. I can prepare separate PR for logs |
pdelewski
force-pushed
the
SUMO-186628-Adjust-queueing-and-batching-configurarion-for-OTC
branch
from
0c61160
to
b1812cc
Compare
pdelewski
deleted the
SUMO-186628-Adjust-queueing-and-batching-configurarion-for-OTC
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng results
Description
Fill in your description here.
Checklist
Testing performed