-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for NodeSelector and Tolerations #255
Conversation
/assign @frankreno |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like our CI isn't picking up PRs, only pushes, so it hasn't auto-generated a yaml.
Would like to close this PR in favor of #256
@rvmiller89 how can I create PR in the future which won't force your to duplicate ? |
We'll be working on the Travis CI build script today so that future PRs will auto-generate yaml changes. So this should be a one-time workaround to get this merged today. |
Perfect, closing! |
Description
Both Deployment and EventDepoyment don't support configuring NodeSelector, in hybrid clusters (windows+linux), this is a must.
Testing performed
--- No support for OSX