Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for NodeSelector and Tolerations #255

Closed
wants to merge 6 commits into from

Conversation

djsly
Copy link
Contributor

@djsly djsly commented Oct 29, 2019

Description

Both Deployment and EventDepoyment don't support configuring NodeSelector, in hybrid clusters (windows+linux), this is a must.

Testing performed
  • [X ] ci/build.sh
    --- No support for OSX
11:39 $ ci/build.sh 
Starting build process in: /Users/sylvain_boily/git/djsly/sumologic-kubernetes-collection with version tag: 0.0.0
Building gem fluent-plugin-carbon-v2 version 0.0.0 in /Users/sylvain_boily/git/djsly/sumologic-kubernetes-collection/fluent-plugin-carbon-v2 ...
Install bundler...
ci/build.sh: /usr/local/bin/bundle: /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/bin/ruby: bad interpreter: No such file or directory
Script error on line 39
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@djsly
Copy link
Contributor Author

djsly commented Oct 29, 2019

/assign @frankreno

@djsly djsly changed the title Adding support for NodeSelector Adding support for NodeSelector and Tolerations Oct 29, 2019
Copy link
Contributor

@rvmiller89 rvmiller89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like our CI isn't picking up PRs, only pushes, so it hasn't auto-generated a yaml.

Would like to close this PR in favor of #256

deploy/helm/sumologic/templates/events-deployment.yaml Outdated Show resolved Hide resolved
deploy/helm/sumologic/templates/events-deployment.yaml Outdated Show resolved Hide resolved
deploy/helm/sumologic/templates/deployment.yaml Outdated Show resolved Hide resolved
@djsly
Copy link
Contributor Author

djsly commented Oct 29, 2019

@rvmiller89 how can I create PR in the future which won't force your to duplicate ?

@rvmiller89
Copy link
Contributor

We'll be working on the Travis CI build script today so that future PRs will auto-generate yaml changes. So this should be a one-time workaround to get this merged today.

@djsly
Copy link
Contributor Author

djsly commented Oct 29, 2019

Perfect, closing!

@djsly djsly closed this Oct 29, 2019
@djsly djsly deleted the fix-for-nodeSelectorSupport branch October 29, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants