fix(setup): allow credentials to not be set if setup is disabled #2572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A recent change moved setup credentials to a temporary Secret, but failed to make this Secret conditional on setup being enabled. As a result, it's necessary to provide credentials even if setup is disabled, which is incorrect.
This PR doesn't include a test because our Helm template test framework doesn't allow not setting credentials in tests. I'll look into adding a test using Terratest instead in a separate PR.
Checklist