feat(logs): Changing the default logs metadata provider to otel #2621
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rnishtala-sumo
force-pushed
the
rnishtala-otel-default
branch
from
48a806f
to
578b009
Compare
| "cluster": "kubernetes", | ||
| "namespace": internal.LogsGeneratorName, | ||
| "pod_labels_app": internal.LogsGeneratorName, | ||
| "container": internal.LogsGeneratorName, | ||
| "deployment": internal.LogsGeneratorName, | ||
| "replicaset": "", | ||
| "namespace_id": "", | ||
| "pod": "", | ||
| "pod_id": "", | ||
| "container_id": "", | ||
| "host": "", | ||
| "master_url": "", | ||
| "node": "", | ||
| "_sourceName": "", | ||
| "_sourceCategory": "", | ||
| "_sourceHost": "", |
There was a problem hiding this comment.
Why do we removed some of the expected metadata?
There was a problem hiding this comment.
the expected metadata changes for otelcol, it has an additional entry and a few other changes like below:
"_collector": "kubernetes"
There was a problem hiding this comment.
I'm curious what happened with _source*, these are pretty crucial fields and we should have it in sumo 😬
There was a problem hiding this comment.
got it, I have added those _source* fields to the tests and pushed the changes, and the tests do pass.
| - hostPath: | ||
| path: /run/log/journal | ||
| type: DirectoryOrCreate | ||
| name: run-log-journal |
There was a problem hiding this comment.
| name: run-log-journal | |
| name: run-log-journal | |
| }). | ||
| Feature() | ||
|
|
||
| featMetrics := features.New("metrics"). |
There was a problem hiding this comment.
If this is a logs test (as name implies), then why do we test the metrics?
There was a problem hiding this comment.
that's a good point I'll remove the metrics tests and only keep the logs tests.
|
@swiatekm-sumo it looks like we need changes like these in the tests (outside values.yaml for the tests) when we change the logs default to otelcol, for the tests to pass. |
rnishtala-sumo
force-pushed
the
rnishtala-otel-default
branch
from
578b009
to
04754f1
Compare
What I meant was that you should instead change this config file: https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/main/tests/integration/values/values_helm_default_fluentd_metadata.yaml to use fluentd as the provider. |
rnishtala-sumo
force-pushed
the
rnishtala-otel-default
branch
from
04754f1
to
4b1b1d9
Compare
rnishtala-sumo
force-pushed
the
rnishtala-otel-default
branch
from
4b1b1d9
to
6ad07d1
Compare
rnishtala-sumo
requested review from
swiatekm,
andrzej-stencel and
sumo-drosiek
Description
Checklist
Testing performed