feat!: refactor metrics metadata config #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
force-pushed
the
feat/metrics-metadata-config
branch
from
d11d8fa
to
3130b26
Compare
swiatekm
force-pushed
the
feat/metrics-metadata-config
branch
from
3130b26
to
b00669c
Compare
swiatekm
force-pushed
the
feat/metrics-metadata-config
branch
from
b00669c
to
acdb79b
Compare
swiatekm
force-pushed
the
feat/metrics-metadata-config
branch
from
acdb79b
to
217c219
Compare
swiatekm
force-pushed
the
feat/metrics-metadata-config
branch
2 times, most recently
from
6efa304
to
81a0f6f
Compare
rnishtala-sumo
approved these changes
Nov 23, 2022
swiatekm
force-pushed
the
feat/metrics-metadata-config
branch
from
81a0f6f
to
4567de1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the metrics metadata configuration to a template. We don't do much more here, there are more changes expected later, pulling out some of the configuration to top-level properties.
I've added two different ways of customizing the configuration directly. The contents of
metadata.metrics.config.mergewill be merged into the templated configuration, whilemetadata.metrics.config.overridewill replace it in total.Migration can be found here: SumoLogic/sumologic-kubernetes-tools#380.
Checklist