-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): simplify custom application metrics #2716
Conversation
e1ac9e3
to
875fd43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add one or two template tests to check if metric.remotewrites
works correctly with both our ServiceMonitors and the additional ones?
@swiatekm-sumo I assume you were meaning |
@@ -0,0 +1,15 @@ | |||
kube-prometheus-stack: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nicer if this was a Go test instead, we could avoid the output templates and just check if the servicemonitor names in the list are right.
0630627
to
dbbc48a
Compare
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Co-authored-by: Mikołaj Świątek <mswiatek@sumologic.com>
Co-authored-by: Mikołaj Świątek <mswiatek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Co-authored-by: Andrzej Stencel <astencel@sumologic.com>
…true Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
21f7615
to
027f34f
Compare
Co-authored-by: Andrzej Stencel <astencel@sumologic.com>
Description
sumologic.metrics.serviceMonitors
to keep our serviceMonitors configurationadditionalServiceMonitors
empty, so customer doesn't need to copy anythingChecklist
Testing performed