feat: add otellogs.additionalDaemonSets configuration #2750
Conversation
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ## additionalDaemonSets allows to set daemonsets with affinity, nodeSelector and resources | ||
| ## different than the main DaemonSet | ||
| ## Be careful and set nodeAffinity for the main DaemonSet, | ||
| ## as we do not support multiple pods of otellogs on the same node |
There was a problem hiding this comment.
@SumoLogic/open-source-collection-team
Do you think it is safe assumption that if customer needs to set it, thew will know how to do it properly?
Or could we limit configuration to nodeSelector and figure out nodeAffinities by ourselves?
There was a problem hiding this comment.
Let them figure it out imo, they should know what they're doing if they need to use this.
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
|
If we want to add this feature, we need to document it and provide examples. With proper documentation and the examples in place, I think we should be safe. |
deploy/helm/sumologic/values.yaml
Outdated
| ## operator: NotIn | ||
| ## values: | ||
| ## - linux | ||
| additionalDaemonSets: [] |
There was a problem hiding this comment.
How about a map of named daemonsets? This might make it easier to use this feature, having a daemonset named e.g. otelcol-logs-collector-hpc instead of otelcol-logs-collector-1. Just a suggestion, it has its ins and outs (like making the names too long).
There was a problem hiding this comment.
this is actually a good idea. I will work on it
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
…erent nodes Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
changed the title
sumo-drosiek
changed the title
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
deploy/helm/sumologic/templates/logs/collector/otelcol/daemonset.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Mikołaj Świątek <mswiatek@sumologic.com>
I think it could be in both |
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
|
false positive markdown link check (checked manually) |
Description
Fill in your description here.
Checklist
Testing performed