fix(logs): fix metadata for pods with more than one container #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
andrzej-stencel
force-pushed
the
fix-container-metadata-for-container-logs
branch
from
8524148
to
0c71c40
Compare
Fixes #2862 The `containerName` metadata extraction gives incorrect results for pods with more than one containers. We don't need this extraction anyway, because container logs already have the `k8s.container.name` attribute from log file name.
andrzej-stencel
force-pushed
the
fix-container-metadata-for-container-logs
branch
from
0c71c40
to
b0cae06
Compare
andrzej-stencel
changed the title
sumo-drosiek
approved these changes
Feb 10, 2023
|
Could we add some tests for it? |
|
I'll do this separately. I don't want this fix to be slowed down by adding a new integration test for this - which isn't trivial. |
andrzej-stencel
deleted the
fix-container-metadata-for-container-logs
branch
andrzej-stencel
added a commit
that referenced
this pull request
Feb 13, 2023
andrzej-stencel
added a commit
that referenced
this pull request
Feb 13, 2023
andrzej-stencel
added a commit
that referenced
this pull request
Feb 13, 2023
andrzej-stencel
added a commit
that referenced
this pull request
Feb 13, 2023
andrzej-stencel
added a commit
that referenced
this pull request
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2862
The
containerNamemetadata extraction gives incorrect results for pods with more than one containers.We don't need this extraction anyway, because container logs already have the
k8s.container.nameattribute from log file name.