Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(metrics): remove deprecated apiserver metrics #2898

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

swiatekm
Copy link

@swiatekm swiatekm commented Feb 27, 2023

apiserver_request_latencies_* metrics were deprecated in 1.14 and disabled in 1.17. The current replacement are apiserver_request_duration_*. Enable checking these in integration tests.

Fix another small issue in the changelog generation script as well.

Checklist

  • Changelog updated or skip changelog label added
  • Integration tests added or modified for major features

@swiatekm swiatekm requested a review from a team as a code owner February 27, 2023 14:50
@swiatekm swiatekm force-pushed the fix/controller-manager-metrics branch from 8eb2457 to d4ff3b1 Compare February 27, 2023 14:52
@swiatekm swiatekm force-pushed the fix/controller-manager-metrics branch from d4ff3b1 to 4d05342 Compare February 27, 2023 15:31
@swiatekm swiatekm changed the title fix: collect the right apiserver metrics chore(metrics): remove deprecated apiserver metrics Feb 27, 2023
@swiatekm swiatekm force-pushed the fix/controller-manager-metrics branch from 4d05342 to b8636a1 Compare February 27, 2023 15:33
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use them in the Kubernetes app dashboard?

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have duplications

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have duplications

NVM, serviceMonitor and remoteWrite

@swiatekm
Copy link
Author

Do we use them in the Kubernetes app dashboard?

Not as far as I'm aware, there's a separate app for control planes on managed K8s. And they don't exist anyway, so removing them from the config doesn't change anything.

@swiatekm swiatekm merged commit 1382dc2 into main Feb 28, 2023
@swiatekm swiatekm deleted the fix/controller-manager-metrics branch February 28, 2023 09:25
swiatekm pushed a commit that referenced this pull request Mar 23, 2023
This was unnecessarily enabled in #2898. It's quite noisy and we don't
actually use it in apps.
swiatekm pushed a commit that referenced this pull request Mar 23, 2023
This was unnecessarily enabled in #2898. It's quite noisy and we don't
actually use it in apps.
swiatekm pushed a commit that referenced this pull request Mar 24, 2023
This was unnecessarily enabled in #2898. It's quite noisy and we don't
actually use it in apps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants