feat: rename public.ecr.aws/sumologic/kubectl to public.ecr.aws/sumologic/kubernetes-tools-kubectl #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sumo-drosiek
force-pushed
the
drosiek-rename-kubectl
branch
from
185a67c
to
f6dd16d
Compare
…ogic/kubernetes-tools-kubectl Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-rename-kubectl
branch
from
f6dd16d
to
e60720b
Compare
swiatekm
reviewed
Apr 13, 2023
There was a problem hiding this comment.
LGTM, but I'd like to get SumoLogic/sumologic-kubernetes-tools#500 sorted out first before merging this.
added 2 commits
April 13, 2023 16:44
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
commented
Apr 14, 2023
| @@ -52,7 +52,7 @@ function check_hpa_exists() { | |||
| function get_sorted_pvcs() { | |||
| kubectl -n "${NAMESPACE}" get pvc --selector="${PVC_SELECTOR}" --no-headers \ | |||
| | awk '{print $1}' \ | |||
| | sort --version-sort | |||
| | sort -V | |||
There was a problem hiding this comment.
Busybox doesn't support long arguments
swiatekm
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist