Customizable annotations for setup resources #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdaltonfanduel
changed the title
matthewdaltonfanduel
changed the title
rvmiller89
suggested changes
Nov 19, 2019
added 3 commits
November 19, 2019 15:59
rvmiller89
reviewed
Nov 19, 2019
rvmiller89
approved these changes
Nov 20, 2019
maimaisie
approved these changes
Nov 20, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think that the ability to customize the annotations for helm hooks is important enough to move it out into the values to make it override-able. I also fixed some of the formatting around setup in the values to make it expandable in the future.
Testing performed