fix(logs): systemd logs with otel and Fluent Bit #3042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| @@ -557,8 +558,6 @@ service: | |||
| - groupbyattrs/systemd | |||
| - resource/add_cluster | |||
| - source/kubelet | |||
| - transform/remove_attributes | |||
There was a problem hiding this comment.
I wasn't sure why were removing the log attributes earlier
There was a problem hiding this comment.
We remove them for data from otel log collectors, because there the attributes come in as body attributes. So we delete existing record attributes and then copy attributes from the body to record attributes. Data coming in from Fluent Bit already has this in record attributes.
swiatekm
force-pushed
the
fix/logs/systemd-otel-fluentbit
branch
from
ad4587e
to
6f02e35
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
force-pushed
the
fix/logs/systemd-otel-fluentbit
branch
from
6f02e35
to
010ac42
Compare
andrzej-stencel
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Fluent Bit as the log collector and otel for metadata enrichment, systemd logs would arrive empty in Sumo. The reason for this is that Fluent Bit actually puts the systemd attributes in the equivalent of record attributes, while the otel log collector puts them in the body. The pipelines were the same, which caused the issue.
I've removed the unnecessary processors from the Fluent Bit pipeline.
Checklist