Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting otelcol image globally #3051

Merged
merged 1 commit into from
May 15, 2023

Conversation

swiatekm
Copy link

@swiatekm swiatekm commented May 12, 2023

Add a new config value for setting otelcol image for all components:

sumologic:
  otelcolImage:
      repository: ...
      tag: ...

I've also set all the component-specific settings to be empty and the underlying resources will use the default image in this case.

This is implemented with some rather mundane template functions. Most of the added lines are goldenfile tests I've added, that really should've been there to begin with.

Fixes #2700

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@swiatekm swiatekm force-pushed the feat/set-collector-image-globally branch from 045fc23 to 3aa2be3 Compare May 12, 2023 13:18
@swiatekm swiatekm marked this pull request as ready for review May 12, 2023 13:41
@swiatekm swiatekm requested a review from a team as a code owner May 12, 2023 13:41
@swiatekm swiatekm force-pushed the feat/set-collector-image-globally branch from 3aa2be3 to a824607 Compare May 12, 2023 13:41
@aboguszewski-sumo
Copy link
Contributor

I guess this will resolve #2700?

@swiatekm swiatekm force-pushed the feat/set-collector-image-globally branch 2 times, most recently from 8a6ab3c to 39e19df Compare May 15, 2023 14:30
@swiatekm swiatekm enabled auto-merge (rebase) May 15, 2023 14:32
@swiatekm swiatekm merged commit 82ecb90 into main May 15, 2023
@swiatekm swiatekm deleted the feat/set-collector-image-globally branch May 15, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add single otelcol.image section for all of the components and allow overrides for each component separately
3 participants