fix filter plugin error with kubernetes_meta_reduce #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsinghal13
approved these changes
Dec 2, 2019
maimaisie
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unfortunately we found that if
kubernetes_metais set tofalseandkubernetes_meta_reduceis set totrueat the same time, this plugin tries to delete keys fromrecord["kubernetes"], which has been deleted previously and is therefore nil.At the very least this spams fluentd logs with the error, which is self collected and creates a nasty loop.
At worst, we believe this may have caused container logs to be dropped due to the unhandled error in this plugin. We should confirm that behavior, and in general handle errors more gracefully in all of our plugins to ensure this sort of issue does not occur again.
Testing performed