-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HorizontalPodAutoscaler for fluentd #339
Changes from all commits
7f119fe
169df02
56d4fff
c2f5225
189f678
f63f2bc
80ea24d
0dc2207
0eee516
a7c3da0
c95fa2a
0c29e1d
61f1714
773ac58
2f12518
be04863
6f9e198
f6d419c
e43cae5
75a695c
6fde744
4b4b6a6
030126d
12c5c71
8903708
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# This file is auto-generated. | ||
args: | ||
- --kubelet-insecure-tls | ||
- --kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
{{- if .Values.sumologic.fluentd.autoscaling.enabled}} | ||
apiVersion: autoscaling/v1 | ||
kind: HorizontalPodAutoscaler | ||
metadata: | ||
name: {{ template "sumologic.fullname" . }} | ||
labels: | ||
app: {{ template "sumologic.labels.app" . }} | ||
{{- include "sumologic.labels.common" . | nindent 4 }} | ||
spec: | ||
scaleTargetRef: | ||
apiVersion: apps/v1 | ||
kind: Deployment | ||
name: {{ template "sumologic.fullname" . }} | ||
minReplicas: {{ .Values.sumologic.fluentd.autoscaling.minReplicas }} | ||
maxReplicas: {{ .Values.sumologic.fluentd.autoscaling.maxReplicas }} | ||
targetCPUUtilizationPercentage: {{ .Values.sumologic.fluentd.autoscaling.targetCPUUtilizationPercentage }} | ||
{{- end -}} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -164,6 +164,12 @@ sumologic: | |
fluentd: | ||
## Option to specify the Fluentd buffer as file/memory. | ||
buffer: "memory" | ||
## Option to turn autoscaling on for fluentd and specify metrics for HPA. | ||
autoscaling: | ||
enabled: false | ||
minReplicas: 3 | ||
maxReplicas: 10 | ||
targetCPUUtilizationPercentage: 50 | ||
|
||
k8sMetadataFilter: | ||
## Option to control the enabling of metadata filter plugin watch. | ||
|
@@ -181,6 +187,15 @@ sumologic: | |
## ref: https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter#configuration | ||
bearerCacheTtl: "3600" | ||
|
||
|
||
## Configure metrics-server | ||
## ref: https://github.com/helm/charts/blob/master/stable/metrics-server/values.yaml | ||
metrics-server: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we need to teach our CI to generate There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess it will be required if we want to add the arguments. |
||
enabled: true | ||
args: | ||
- --kubelet-insecure-tls | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I could see customers having an issue with using this in an insecure way. Is there any other way to run this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Without using that the metrics server is unable to get metrics. Will look into it more if we can avoid this. |
||
- --kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname | ||
|
||
## Configure fluent-bit | ||
## ref: https://github.com/helm/charts/blob/master/stable/fluent-bit/values.yaml | ||
fluent-bit: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -656,3 +656,6 @@ spec: | |
value: "100k" | ||
- name: TOTAL_LIMIT_SIZE | ||
value: "128m" | ||
--- | ||
# Source: sumologic/templates/hpa.yaml | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vsinghal13 will autoscaling be OFF by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, by default it will be off as of now.