disable metrics-server dependency by default #358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disabled the
metrics-server
helm chart dependency by default.metrics-server
is only required for thefluentd
HPA , which is disabled by default, so we are also defaulting this dependency tofalse
.It is primarily done to cover the scenario, where the user already has
metrics-server
installed in the k8s cluster, then our helm install command would fail with the error :Error: release collection failed: apiservices.apiregistration.k8s.io "v1beta1.metrics.k8s.io" already exists
Now, if the user wants to enable autoscaling for fluentd they will have to do the following steps:
metrics-server
dependencyNote: if
metrics-server
is already installed , this step is not required2.Enable autoscaling for fluentd
Testing performed
helm install
command and verified that helm install and upgrade are successful