SUMO-124885 attach logs metadata as fields for all log formats #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did CI fail on this one? |
|
Hmm strange, CI passed on this PR but it didn't report it: https://travis-ci.org/SumoLogic/sumologic-kubernetes-collection/builds/634976511 |
|
maybe merge master to kick off CI again |
…llection into ssong-logs-metadata-always
maimaisie
approved these changes
Jan 10, 2020
rvmiller89
approved these changes
Jan 10, 2020
| }, | ||
| } | ||
| assert_equal(1, d.filtered_records.size) | ||
| assert_equal(d.filtered_records[0], expected) | ||
| assert_equal(expected, d.filtered_records[0]) |
There was a problem hiding this comment.
thanks for fixing all these
vsinghal13
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
as a short term workaround, we attach logs metadata as fields regardless of the log format (fields, json, text, json_merge)
this will enable the use of text format with metadata, but multiline detection will be broken, as it was for the old kubernetes collection solution.
Testing performed