-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose cache params for enhance_k8s_metadata plugin #379
Conversation
…t cache size to 10000
…b.com/SumoLogic/sumologic-kubernetes-collection into vsinghal-expose-metadata-cache-params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that these values should probably be controlled by the same config in the values.yaml
file but it's a little confusing that they go under k8sMetadataFilter
and reference the 3rd party plugin docs
though I suppose if we want to be minimally intrusive here, we don't have much of a choice but to keep them under k8sMetadataFilter
:(
…b.com/SumoLogic/sumologic-kubernetes-collection into vsinghal-expose-metadata-cache-params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Expose cache params for enhance_k8s_metadata plugin and change default cache size to 10000
Testing performed