fix discrepancy in metadata cache ENV name #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samjsong
reviewed
Jan 30, 2020
| cache_size "#{ENV['K8S_METADATA_FILTER_BEARER_CACHE_SIZE']}" | ||
| cache_ttl "#{ENV['K8S_METADATA_FILTER_BEARER_CACHE_TTL']}" | ||
| cache_size "#{ENV['K8S_METADATA_FILTER_CACHE_SIZE']}" | ||
| cache_ttl "#{ENV['K8S_METADATA_FILTER_CACHE_TTL']}" |
There was a problem hiding this comment.
Can we also change lines 33-34 to use the env var, as well as in the metrics.conf, for consistency? Once we make the major release we can use the templating this way as it is cleaner but until then I think we should stay consistent with the use of env vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix discrepancy in metadata cache ENV name
Testing performed