Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common configuration and troubleshooting tasks #408

Merged
merged 8 commits into from
Feb 12, 2020

Conversation

vsinghal13
Copy link
Contributor

@vsinghal13 vsinghal13 commented Feb 11, 2020

Description

This PR add common configuration and troubleshooting tasks which will help the customer
to customize the solution as per their needs.

Configs added:

  1. Excluding logs/metrics for certain namespace/container
  2. Configure local fluent-bit source
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool, you added these! Thanks for taking care of this. LGTM :)

@@ -4,149 +4,7 @@
clusterName: "kubernetes"
},
sumologicCollector:: {
remoteWriteConfigs+: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this file change? Something in the CI?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, good catch Frank. @vsinghal13 can you take a look please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.. looks like something in the CI. will take a look.

Copy link
Contributor Author

@vsinghal13 vsinghal13 Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build.sh copies the remote write section from the prometheus-overrides.yaml to this file and then does a git diff to generate new files, but there is no change in the remote write config in this PR.

@vsinghal13 vsinghal13 merged commit 801e0df into master Feb 12, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-troubleshooting-doc branch February 12, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants