Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vagrant configuration for testing purposes #418

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Add vagrant configuration for testing purposes #418

merged 1 commit into from
Mar 27, 2020

Conversation

sumo-drosiek
Copy link
Contributor

Description

I wrote simple vagrant scripts to have repeatable development environment

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek
Copy link
Contributor Author

I definitely going to write README for vagrant if we would like to go with it for master. For now:

please create vagrant/envs.sh with your access and id values:

#!/bin/bash

ENDPOINT='sumologic api endpoint'
ACCESS_KEY='your sumologic access key'
ACCESS_ID='your sumologic access id'

perk-sumo
perk-sumo reviewed Feb 13, 2020
View reviewed changes
vagrant/provision.sh Outdated
microk8s.enable registry
microk8s.enable storage
microk8s.enable dns
microk8s.enable prometheus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant this line only: microk8s.enable prometheus

perk-sumo
perk-sumo reviewed Feb 13, 2020
View reviewed changes
vagrant/provision.sh Outdated
apt-get install --yes iptables-persistent

#snap alias microk8s.helm helm
helm init --wait
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work only for the root user. Please run as a vagrant user.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works fine for me, why? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand

    default: + su vagrant -c helm init --wait
    default: bash: helm: command not found
    default: + usermod -a -G microk8s vagrant
    default: usermod: group 'microk8s' does not exist

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK provisioning is run under root account.
As for those errors it seems microk8s has not been installed correctly.

perk-sumo
perk-sumo reviewed Feb 13, 2020
View reviewed changes
Vagrantfile Outdated
config.vm.box_check_update = false
config.vm.host_name = 'sumologic-kubernetes-collection-dev.vagrantup.com'

config.vm.network :forwarded_port, guest: 18080, host: 18080
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port forwards are not needed with :private_network, those will just work out of the box. Please remove.

perk-sumo
perk-sumo reviewed Feb 13, 2020
View reviewed changes
Vagrantfile Outdated
Vagrant.configure('2') do |config|
config.vm.box = 'ubuntu/bionic64'
config.vm.box_check_update = false
config.vm.host_name = 'sumologic-kubernetes-collection-dev.vagrantup.com'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove -dev.vagrantup.com

perk-sumo
perk-sumo reviewed Feb 13, 2020
View reviewed changes
Vagrantfile Outdated
vb.gui = false
vb.cpus = 8
vb.memory = 16384
vb.name = 'sumologic-kubernetes-collection-dev'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove -dev.

frankreno
frankreno approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samjsong
samjsong approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool, will probably save lots of time moving forward, thanks!

vsinghal13
vsinghal13 approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perk-sumo perk-sumo force-pushed the drosiek-vagrant branch 2 times, most recently from c45b112 to a0d8d6b Compare March 27, 2020 10:15
@perk-sumo perk-sumo changed the base branch from drosiek-zipkin-helm-config to master March 27, 2020 10:15
@perk-sumo perk-sumo force-pushed the drosiek-vagrant branch 3 times, most recently from 4b7d21c to 17fc114 Compare March 27, 2020 11:04
sumo-drosiek
sumo-drosiek commented Mar 27, 2020
View reviewed changes
Copy link
Contributor Author

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @perk-sumo

@perk-sumo perk-sumo force-pushed the drosiek-vagrant branch 2 times, most recently from 10e502c to 0916782 Compare March 27, 2020 11:20
@sumo-drosiek sumo-drosiek merged commit 454abb6 into master Mar 27, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-vagrant branch March 27, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk-sumo perk-sumo perk-sumo left review comments

@frankreno frankreno frankreno approved these changes

@samjsong samjsong samjsong approved these changes

@vsinghal13 vsinghal13 vsinghal13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sumo-drosiek @frankreno @samjsong @vsinghal13 @perk-sumo