-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add affinity config in fluentd deployment #436
Conversation
- key: app | ||
operator: In | ||
values: | ||
- prometheus-operator-prometheus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section checks for the prometheus app label.
- key: app | ||
operator: In | ||
values: | ||
- {{ template "sumologic.labels.app" . }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section checks for the fleuntd app label.
operator: In | ||
values: | ||
- prometheus-operator-prometheus | ||
topologyKey: "kubernetes.io/hostname" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The topologyKey
is the label for a particular node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Adding @perk-sumo as a reviewer as he has some experience with this as well.
@@ -6,7 +6,7 @@ | |||
sumologicCollector:: { | |||
remoteWriteConfigs+: [ | |||
{ | |||
url: $._config.sumologicCollectorSvc + "prometheus.metrics.state", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those changes OK? Why they were expanded now with this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been fixed, by merging master into the branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the libsonnet changes that I'm not sure about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one minor comment
@@ -8,6 +8,8 @@ nameOverride: "" | |||
deployment: | |||
nodeSelector: {} | |||
tolerations: {} | |||
affinity: {} | |||
podAntiAffinity: "soft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also leave a comment here for the customers that the accepted values are "soft" and "hard", and what those mean?
Description
This PR exposes the use of
podAntiAffinity
to better schedule the fluentd replicas and prometheus pods across nodes.By default, we are using a
preferredDuringSchedulingIgnoredDuringExecution
configuration aliassoft
which will check the conditions and schedule accordingly even if the conditions are not met.The
requiredDuringSchedulingIgnoredDuringExecution
configuration aliashard
will keep the pods in Pending state if any of the conditions are not met.Conditions:
Testing performed