Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.0] Revert "Revert "[breaking change] Add pre-upgrade hook for setup"" #446

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

maimaisie
Copy link
Contributor

Reverts #357

@maimaisie
Copy link
Contributor Author

I think this is needed especially now that we have the new traces source

@samjsong samjsong changed the title Revert "Revert "[breaking change] Add pre-upgrade hook for setup"" [1.0.0] Revert "Revert "[breaking change] Add pre-upgrade hook for setup"" Feb 24, 2020
@samjsong
Copy link
Contributor

cc @sumo-drosiek

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)

@samjsong samjsong merged commit ca46aa0 into master Feb 26, 2020
@samjsong samjsong deleted the revert-357-revert-335-maisie-pre-upgrade-revert branch February 26, 2020 07:43
@samjsong samjsong mentioned this pull request Mar 9, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants