-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose setting resource constraints for helm dependencies #464
Expose setting resource constraints for helm dependencies #464
Conversation
Closed and reopened to trigger the Travis CI again. |
@@ -337,6 +337,15 @@ metrics-server: | |||
## Configure fluent-bit | |||
## ref: https://github.com/helm/charts/blob/master/stable/fluent-bit/values.yaml | |||
fluent-bit: | |||
## Resource limits for fluent-bit | |||
resources: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe prometheus operator does not have default resource limits defined, can we confirm whether fluent-bit has any default resource limits? otherwise this would be overriding the defined defaults
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no default limits for 2.8.1 version: https://github.com/helm/charts/blob/866c1da688dc13d176a9b251ff4636a162c6a735/stable/fluent-bit/values.yaml#L187
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
04db3ad
to
3b5d8f8
Compare
Description
This PR exposes setting resource constraints for fluentbit, prometheus, prometheus-operator.
Testing performed