Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve zipkin plugins #469

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Conversation

sumo-drosiek
Copy link
Contributor

@sumo-drosiek sumo-drosiek commented Mar 6, 2020

Description
  • Re-route unsuccessfully sent traces back to the fluentd
  • Add information about first trace passing the pipeline
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

 * Re-route unsuccessfully sent traces back to the fluentd
 * Add information about first trace passing the pipeline
Copy link
Contributor

@pmm-sumo pmm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumo-drosiek sumo-drosiek merged commit 2bfa59f into master Mar 6, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-reroute-unsuccessful-traces branch March 6, 2020 13:22
@sumo-drosiek sumo-drosiek added this to the v0.16 milestone Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants