Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not drop record in filter if it's 'broken' #480

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

sumo-drosiek
Copy link
Contributor

Description

Do not drop record in filter if it's 'broken'

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sumo-drosiek sumo-drosiek added this to the v0.16 milestone Mar 10, 2020
Copy link
Contributor

@pmm-sumo pmm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see it

@sumo-drosiek sumo-drosiek merged commit 2d6fd18 into master Mar 10, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-dont-drop-records-in-filter branch March 10, 2020 15:54
@samjsong
Copy link
Contributor

Awesome, thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants