-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use memory_limiter and better batch settings #488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add some comments to keep in mind what those processors are for, and why they are in this specific order
otherwise 👍
# Maximum amount of memory, in MiB, targeted to be allocated by the process heap. | ||
# Note that typically the total memory usage of process will be about 50MiB higher | ||
# than this value. | ||
limit_mib: 1900 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We set 2048 (2Gi) as a limit so this should be OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Updates otelcol config (as the title says) and bumps collector version
Testing performed