Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1 fluentd config examples #625

Merged
merged 4 commits into from
May 15, 2020
Merged

v1 fluentd config examples #625

merged 4 commits into from
May 15, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

samjsong
samjsong reviewed May 14, 2020
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, left a few comments but otherwise LGTM

deploy/docs/v1_conf_examples.md Outdated Show resolved Hide resolved
deploy/docs/v1_conf_examples.md Outdated Show resolved Hide resolved
deploy/docs/v1_conf_examples.md Outdated Show resolved Hide resolved
deploy/docs/v1_conf_examples.md Outdated Show resolved Hide resolved
deploy/docs/v1_conf_examples.md Show resolved Hide resolved
deploy/docs/v1_conf_examples.md Outdated Show resolved Hide resolved
sumo-drosiek
sumo-drosiek reviewed May 14, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just some minors, great job 🥇

@vsinghal13 vsinghal13 added this to the v1.0 milestone May 14, 2020
@vsinghal13 vsinghal13 added the documentation documentation label May 14, 2020
frankreno
frankreno approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tweaks, but LGTM

deploy/docs/v1_conf_examples.md Outdated Show resolved Hide resolved
deploy/docs/v1_conf_examples.md Outdated Show resolved Hide resolved
deploy/docs/v1_conf_examples.md Show resolved Hide resolved
@vsinghal13 vsinghal13 requested a review from drduke1 May 14, 2020 21:29
@vsinghal13 vsinghal13 mentioned this pull request May 14, 2020
Closed
3 tasks
perk-sumo
perk-sumo approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thank you!

@vsinghal13 vsinghal13 merged commit 8181a04 into master May 15, 2020
@vsinghal13 vsinghal13 deleted the vsinghal-v1-conf-doc branch May 15, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samjsong samjsong samjsong left review comments

@sumo-drosiek sumo-drosiek sumo-drosiek left review comments

@frankreno frankreno frankreno approved these changes

@drduke1 drduke1 drduke1 approved these changes

@perk-sumo perk-sumo perk-sumo approved these changes

Assignees
No one assigned
Labels
documentation documentation
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@vsinghal13 @frankreno @drduke1 @samjsong @sumo-drosiek @perk-sumo